Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr into #1384 #1407

Merged
merged 5 commits into from
Jan 10, 2023
Merged

pr into #1384 #1407

merged 5 commits into from
Jan 10, 2023

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Jan 6, 2023

Please see the other PR.

This one:

  • Adds a test for false SSL for the old .ini style of config
  • Adds a shortcut for the pyflyte run/register commands - if no files are detected at all, create for sandbox instead. I think this is okay. The other option would be to fall back to checking the ~/.flyte/config-sandbox.yml file but I think using the code option is a bit cleaner, even though it ties us closer to the flytectl demo port settings.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #1407 (cfacdbf) into update-default-config (03e8954) will increase coverage by 0.01%.
The diff coverage is 90.90%.

❗ Current head cfacdbf differs from pull request most recent head b5f9c67. Consider uploading reports for the commit b5f9c67 to get more accurate results

@@                    Coverage Diff                    @@
##           update-default-config    #1407      +/-   ##
=========================================================
+ Coverage                  69.17%   69.18%   +0.01%     
=========================================================
  Files                        299      296       -3     
  Lines                      28008    27774     -234     
  Branches                    2631     2612      -19     
=========================================================
- Hits                       19374    19216     -158     
+ Misses                      8120     8048      -72     
+ Partials                     514      510       -4     
Impacted Files Coverage Δ
flytekit/configuration/__init__.py 36.87% <0.00%> (+0.24%) ⬆️
tests/flytekit/unit/configuration/test_file.py 100.00% <100.00%> (ø)
tests/flytekit/unit/configuration/test_internal.py 100.00% <100.00%> (ø)
...ests/flytekit/unit/configuration/test_yaml_file.py 100.00% <100.00%> (ø)
flytekit/models/core/identifier.py 33.33% <0.00%> (-4.63%) ⬇️
flytekit/models/admin/workflow.py 26.08% <0.00%> (-2.76%) ⬇️
flytekit/remote/remote.py 39.88% <0.00%> (-2.07%) ⬇️
flytekit/remote/entities.py 80.64% <0.00%> (-0.92%) ⬇️
flytekit/models/task.py 35.79% <0.00%> (-0.36%) ⬇️
flytekit/tools/repo.py 82.75% <0.00%> (-0.15%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit bfdefd3 into update-default-config Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants