-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor interfaces and engine code #153
Merged
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
1a65cef
messing around
ea602fb
doesn't compile
f642ce6
uh
33ebcbd
complete mess
f2bea18
what?
978cb90
fjdksalfj
b664c3d
fixing comments
2707644
merge
4d924a2
merging master
cf59e21
manually construct the workflow outputs
d7be767
adding a couple comments, and using sdk task and workflow
7c05782
temporarily deleting long-running tests, self-naming
9701acc
doesn't work
752cd43
definitely doesn't work
361fba5
remove six
76a14bc
one more six
fa4a935
wip
ded737d
fdsa
74c80c2
wip
1c1efb8
lp
7fa979f
nodes
97d4e8a
workflow execution
ced4cb4
task execution
e0604ce
delete annotated stuff
a1c0c8f
moving stuff from runnable launch plan to sdk launch plan, moving hel…
98d5aa5
minor changes
f6d2b73
add back removed files
6e7ed7d
wip
4aa07fd
wip
17b86e3
add setter to pass through setting
9749409
a test
025736b
wip
a92d09c
tests finally passing
356c2c0
add a serialize function redirect and remove the leftover workflow
5ea2238
move the upstream entities from
2a6a398
call local constructor in workflow
74f212e
wip
8582b6c
isort
a25c5f1
wip
1d604fb
wip
f2cbf4e
what
63b5f7d
run black and isort again
2df757a
ignore build
b2344f9
black exclusion dirs
fb477a7
3.6
e413be1
add back raw output stuff
03faf55
clean up
7068d73
fmt
9bc7e90
lint
6c08e62
add back test
f600a04
remove meta for now
ab7f746
wip
21c1cae
moving
50b40b8
make fmt
0c48927
remove bad comment
c2bc06b
remove part of the duplication with container objects
5492335
move output back to old file
2190a9d
Revert "move output back to old file"
0b7f0ce
comment
16aba83
made PythonWorkflow a subclass of SdkWorkflow just to see if it makes…
d1ba7de
changing around abcs
72b28d5
rename local to trackable
41771e4
changing around abcs once more
667782d
lint and fmt
e1df33c
merge in master again and pull katrina's changes
cda6ca7
merge master
d15e8c9
lint
3fce0ac
wip
bbf92e0
merge master and resolve conflicts
80a3a17
fmt
5b85549
revert
7ecaf58
add back cls override to workflow()
2f1fd89
always need to transform literal map
8ae8ec3
same early return fix for executions, but for inputs
4a3604f
refactoring non-engine uses of flyteclientmanager behind a helper fun…
5149145
type hinting
6e765b5
lint
a119929
remove rest of future stuff
99959b9
removing six metaclass
a4b8f56
removing six metaclass
6aa0f76
forgot to delete
b4bd176
forgot to delete
c285359
lint
cc0eef3
rename PythonWorkflow to SdkRunnableWorkflow, and add a long comment …
e7b23db
change deprecation message version to match
63b28a7
rename alias
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,20 @@ | ||
from __future__ import absolute_import | ||
import logging as _logging | ||
|
||
import flytekit.plugins # noqa: F401 | ||
|
||
__version__ = "0.12.6" | ||
__version__ = "0.13.0b4" | ||
|
||
logger = _logging.getLogger("flytekit") | ||
|
||
# create console handler and set level to debug | ||
ch = _logging.StreamHandler() | ||
ch.setLevel(_logging.DEBUG) | ||
|
||
# create formatter | ||
formatter = _logging.Formatter("%(asctime)s-%(name)s-%(levelname)s$ %(message)s") | ||
|
||
# add formatter to ch | ||
ch.setFormatter(formatter) | ||
|
||
# add ch to logger | ||
logger.addHandler(ch) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import logging as _logging | ||
|
||
import six as _six | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import logging as _logging | ||
import urllib.parse as _urlparse | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import importlib as _importlib | ||
import os as _os | ||
import stat as _stat | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import base64 as _base64 | ||
import logging as _logging | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import logging as _logging | ||
|
||
import click | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
import logging as _logging | ||
|
||
import click | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
from __future__ import absolute_import | ||
|
||
from flytekit.common.exceptions import base as _base_exceptions | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want the level to be DEBUG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. At least for the beta releases right? I'd like to add a lot more debug statements and some info statements too. I'll make it info for the non-beta release.