Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move FlyteSchema deprecation warning to initialization method #1558

Merged
merged 2 commits into from
Mar 23, 2023
Merged

move FlyteSchema deprecation warning to initialization method #1558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dfed17
move FlyteSchema deprecation warning to initialization method
cosmicBboy Mar 22, 2023
b6d778e
update
cosmicBboy Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion flytekit/types/schema/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ class FlyteSchema(object):
"""
This is the main schema class that users should use.
"""
logger.warning("FlyteSchema is deprecated, use Structured Dataset instead.")

@classmethod
def columns(cls) -> typing.Dict[str, typing.Type]:
Expand All @@ -203,6 +202,7 @@ def format(cls) -> SchemaFormat:
def __class_getitem__(
cls, columns: typing.Dict[str, typing.Type], fmt: SchemaFormat = SchemaFormat.PARQUET
) -> Type[FlyteSchema]:
logger.warning("FlyteSchema is deprecated, use Structured Dataset instead.")
if columns is None:
return FlyteSchema

Expand Down Expand Up @@ -240,6 +240,7 @@ def __init__(
supported_mode: SchemaOpenMode = SchemaOpenMode.WRITE,
downloader: typing.Optional[typing.Callable] = None,
):
logger.warning("FlyteSchema is deprecated, use Structured Dataset instead.")
if supported_mode == SchemaOpenMode.READ and remote_path is None:
raise ValueError("To create a FlyteSchema in read mode, remote_path is required")
if (
Expand Down