Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read polar dataframe without copying to local #1618

Merged
merged 1 commit into from
May 4, 2023
Merged

Read polar dataframe without copying to local #1618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions plugins/flytekit-polars/flytekitplugins/polars/sd_transformers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from flytekit.models import literals
from flytekit.models.literals import StructuredDatasetMetadata
from flytekit.models.types import StructuredDatasetType
from flytekit.types.structured.basic_dfs import get_storage_options
from flytekit.types.structured.structured_dataset import (
PARQUET,
StructuredDataset,
Expand Down Expand Up @@ -62,12 +63,12 @@ def decode(
flyte_value: literals.StructuredDataset,
current_task_metadata: StructuredDatasetMetadata,
) -> pl.DataFrame:
local_dir = ctx.file_access.get_random_local_directory()
ctx.file_access.get_data(flyte_value.uri, local_dir, is_multipart=True)
uri = flyte_value.uri
kwargs = get_storage_options(ctx.file_access.data_config, uri)
if current_task_metadata.structured_dataset_type and current_task_metadata.structured_dataset_type.columns:
columns = [c.name for c in current_task_metadata.structured_dataset_type.columns]
return pl.read_parquet(local_dir, columns=columns, use_pyarrow=True)
return pl.read_parquet(local_dir, use_pyarrow=True)
return pl.read_parquet(uri, columns=columns, use_pyarrow=True, storage_options=kwargs)
return pl.read_parquet(uri, use_pyarrow=True, storage_options=kwargs)


StructuredDatasetTransformerEngine.register(PolarsDataFrameToParquetEncodingHandler())
Expand Down
12 changes: 12 additions & 0 deletions plugins/flytekit-polars/tests/test_polars_plugin_sd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import tempfile

import pandas as pd
import polars as pl
from flytekitplugins.polars.sd_transformers import PolarsDataFrameRenderer
Expand Down Expand Up @@ -79,3 +81,13 @@ def create_sd() -> StructuredDataset:
sd = create_sd()
polars_df = sd.open(pl.DataFrame).all()
assert pl.DataFrame(data).frame_equal(polars_df)

tmp = tempfile.mktemp()
pl.DataFrame(data).write_parquet(tmp)

@task
def t1(sd: StructuredDataset) -> pl.DataFrame:
return sd.open(pd.DataFrame).all()

sd = StructuredDataset(uri=tmp)
t1(sd=sd).frame_equal(polars_df)