Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete removed data persistence classes from docs #1633

Merged
merged 3 commits into from
May 12, 2023
Merged

delete removed data persistence classes from docs #1633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afacfc7
delete removed data persistence classes from docs
cosmicBboy May 11, 2023
064dd9a
dont import ElasticConfig at toplevel
cosmicBboy May 12, 2023
489affe
add pytorch elastic to docs
cosmicBboy May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docs_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:
run: |
sudo apt-get install python3-sphinx
pip install -r doc-requirements.txt
SPHINXOPTS="-W" cd docs && make html
cd docs && SPHINXOPTS="-W" make html
4 changes: 0 additions & 4 deletions flytekit/core/data_persistence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@
:template: custom.rst
:nosignatures:

DataPersistence
DataPersistencePlugins
DiskPersistence
FileAccessProvider
UnsupportedPersistenceOp

"""
import os
Expand Down
2 changes: 1 addition & 1 deletion flytekit/models/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def __init__(
:param flytekit.models.core.types.StructuredDatasetType structured_dataset_type: structured dataset
:param dict[Text, T] metadata: Additional data describing the type
:param flytekit.models.annotation.TypeAnnotation annotation: Additional data
describing the type _intended to be saturated by the client_
describing the type intended to be saturated by the client
"""
self._simple = simple
self._schema = schema
Expand Down
1 change: 1 addition & 0 deletions plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
:toctree: generated/

PyTorch
Elastic
"""

from .task import Elastic, PyTorch
4 changes: 3 additions & 1 deletion plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import Any, Callable, Dict, Optional, Union

import cloudpickle
from flyteidl.plugins.pytorch_pb2 import DistributedPyTorchTrainingTask, ElasticConfig
from flyteidl.plugins.pytorch_pb2 import DistributedPyTorchTrainingTask
from google.protobuf.json_format import MessageToDict

import flytekit
Expand Down Expand Up @@ -227,6 +227,8 @@ def get_custom(self, settings: SerializationSettings) -> Optional[Dict[str, Any]
"""
return super().get_custom(settings)
else:
from flyteidl.plugins.pytorch_pb2 import ElasticConfig

elastic_config = ElasticConfig(
rdzv_backend=self.rdzv_backend,
min_replicas=self.min_nodes,
Expand Down
1 change: 1 addition & 0 deletions plugins/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"flytekitplugins-onnxpytorch": "flytekit-onnx-pytorch",
"flytekitplugins-pandera": "flytekit-pandera",
"flytekitplugins-papermill": "flytekit-papermill",
"flytekitplugins-polars": "flytekit-polars",
"flytekitplugins-ray": "flytekit-ray",
"flytekitplugins-snowflake": "flytekit-snowflake",
"flytekitplugins-spark": "flytekit-spark",
Expand Down