Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change variable names to improve readability #1642

Merged
merged 1 commit into from
May 16, 2023
Merged

Change variable names to improve readability #1642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions flytekit/tools/repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,14 +254,14 @@ def register(
options = Options.default_from(k8s_service_account=service_account, raw_data_prefix=raw_data_prefix)

# Load all the entities
serializable_entities = load_packages_and_modules(
registrable_entities = load_packages_and_modules(
serialization_settings, detected_root, list(package_or_module), options
)
if len(serializable_entities) == 0:
if len(registrable_entities) == 0:
click.secho("No Flyte entities were detected. Aborting!", fg="red")
return

for cp_entity in serializable_entities:
for cp_entity in registrable_entities:
og_id = cp_entity.id if isinstance(cp_entity, launch_plan.LaunchPlan) else cp_entity.template.id
secho(og_id, "")
try:
Expand All @@ -274,4 +274,4 @@ def register(
secho(og_id, reason="Dry run Mode!")
except RegistrationSkipped:
secho(og_id, "failed")
click.secho(f"Successfully registered {len(serializable_entities)} entities", fg="green")
click.secho(f"Successfully registered {len(registrable_entities)} entities", fg="green")