Pickle as a default Transformer rather than a special case of function signatures #1661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Right now only "top level" missing types (those defined directly in a function) are pickled if they don't have a registered
TypeTransformer
. This PR alters that behavior to anywhereTypeTransformer
s are used.Type
Are all requirements met?
Complete description
The special casing for pickling as a serialization/deserialization method leads to some strange behavior where, e.g
Is valid, because that type is converted, but e.g.
Foo
inside of a dataclass etc is not. Because the conversion to the placeholderFlytePickle
type happens in a function which is only called once on top level type, and only traverses theorigin
stack, rather than being used anywhereTypeTransformers
are used. This PR fixes that problem, while also significantly simplifying the logic to support it.Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/