Fix a bug in gx integration #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Shi <[email protected]>
Signed-off-by: Xin Shi <[email protected]>
XinEDprob
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
==========================================
+ Coverage 71.00% 71.03% +0.02%
==========================================
Files 336 336
Lines 30781 30798 +17
Branches 5576 5589 +13
==========================================
+ Hits 21855 21876 +21
+ Misses 8379 8375 -4
Partials 547 547 |
pingsutw
reviewed
Jun 6, 2023
|
@pingsutw thanks for letting me know. Will take a look at the test and finish the corresponding change in this week. |
Signed-off-by: Xin Shi <[email protected]>
Signed-off-by: Xin Shi <[email protected]>
pingsutw
previously approved these changes
Jun 15, 2023
pingsutw
reviewed
Jun 23, 2023
plugins/flytekit-greatexpectations/flytekitplugins/great_expectations/task.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Shi <[email protected]>
pingsutw
previously approved these changes
Jun 23, 2023
pingsutw
reviewed
Jun 23, 2023
Signed-off-by: Xin Shi <[email protected]>
pingsutw
approved these changes
Jun 25, 2023
|
@pingsutw do you have any insights about why there is an error in the test? I do not think my changes may affect that part. |
|
@XinEDprob nvm, that's a flaky test. merged it |
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed a bug in the integration of Flyte and Great Expectations. Without this fix, pyspark dataframe will always be converted to pandas dataframe in Great Expectations. As a result, there will have an error when people want to use
SparkDFExecutionEngine.Type
Are all requirements met?
Complete description
I use
selected_datasource[0]["execution_engine"]["class_name"]to recognize theexecution_enginedeclared by the user for Great Expectations. If it is aSparkDFExecutionEngine, the data which is in the form FlyteSchema is converted topyspark.sql.dataframe.DataFrame, else transform the data to the defaultpandas.dataframe.Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA