Fix task type version in pytorch and mpi task plugin #1690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Previously the pytorch plugin is missing comments. We would suggest user to not set configurations for individual replica groups as they should essentially be the same for worker and master. The only fields user should set is number of worker and restart policies.
Fix a bug in pytorch and mpijob to use task type version 1.
Should be merged in after: flyteorg/flyteplugins#359
Type
Are all requirements met?
Complete description
Smoke tested on the following with corrected backend plugin