Raise an exception in case of local execution of raw containers tasks #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardo apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw and
cosmicBboy
as code owners
…-locally Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]>
pingsutw
reviewed
Jul 18, 2023
| for k, v in self.environment.items(): | ||
| env += f" -e {k}={v}" | ||
| print( | ||
| f"\ndocker run --rm -v /tmp/inputs:{self._input_data_dir} -v /tmp/outputs:{self._output_data_dir} {env}" |
There was a problem hiding this comment.
qq: Why can't we run it with Docker?
There was a problem hiding this comment.
That'd be an interesting feature, we have to assume that the docker client is configured properly (which I think it's a fair assumption). In order for this to happen we have to solve a few problems:
- literals and promise generation. This can be easily done in
local_execute. - Detect some features that we can't implement locally, for example pod templates.
There was a problem hiding this comment.
I opened flyteorg/flyte#3876 to track this work.
pingsutw
approved these changes
Jul 18, 2023
2 tasks
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
…#1745) * Raise an exception in case of local raw containers Signed-off-by: eduardo apolinario <[email protected]> * Remove ContainerTask tests from test_type_hints Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
ditto
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#3833
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/