Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rdzv_configs to kfpytorch elastic #1751

Merged
merged 2 commits into from
Jul 21, 2023
Merged

add rdzv_configs to kfpytorch elastic #1751

merged 2 commits into from
Jul 21, 2023

Conversation

Nan2018
Copy link
Contributor

@Nan2018 Nan2018 commented Jul 18, 2023

TL;DR

Adds rdzv_configs to flytekitplugins.kfpytorch.Elastic for additional rdzv configs.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@Nan2018 Nan2018 force-pushed the kfpytorch-rdzv-configs branch from e40ae3f to ec8ca44 Compare July 18, 2023 21:21
fg91
fg91 reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@fg91 fg91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @Nan2018 !

Did you test this locally and in a cluster?

plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py Outdated Show resolved Hide resolved
plugins/flytekit-kf-pytorch/flytekitplugins/kfpytorch/task.py Outdated Show resolved Hide resolved
plugins/flytekit-kf-pytorch/tests/test_elastic_task.py Show resolved Hide resolved
@Nan2018
address cr comments
bc43e7f 
Signed-off-by: Nan2018 <[email protected]>
@Nan2018
Copy link
Contributor Author

Nan2018 commented Jul 19, 2023

Thanks for adding this @Nan2018 !

Did you test this locally and in a cluster?

both

@fg91
Copy link
Member

fg91 commented Jul 19, 2023

Thanks for adding this @Nan2018 !
Did you test this locally and in a cluster?

both

Awesome, thanks 🙏

@Nan2018 Nan2018 requested a review from fg91 July 20, 2023 00:37
pingsutw
pingsutw approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fg91 could we merge this PR?

fg91
fg91 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@fg91 fg91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for incorporating this!

@fg91 fg91 merged commit 55808ec into flyteorg:master Jul 21, 2023
@welcome
Copy link

welcome bot commented Jul 21, 2023

Congrats on merging your first pull request! 🎉

fg91 pushed a commit that referenced this pull request Aug 15, 2023
@Nan2018
add rdzv_configs to kfpytorch elastic (#1751)
ee17dc7 
* add rdzv_configs to kfpytorch elastic
Signed-off-by: Nan2018 <[email protected]>

* address cr comments
Signed-off-by: Nan2018 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@fg91 fg91 fg91 approved these changes

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nan2018 @fg91 @pingsutw