Add agent ctrl-c handler to call the delete function. (Reupload) #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Future-Outlier
force-pushed
the
agent-ctrl-c-handler-v2
branch
from
a61f2cf to
d4f26d7
Compare
added 3 commits
August 9, 2023 13:43
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
force-pushed
the
agent-ctrl-c-handler-v2
branch
from
9bb5590 to
a5ca819
Compare
Signed-off-by: Future Outlier <[email protected]>
11 tasks
pingsutw
approved these changes
Aug 9, 2023
|
Congrats on merging your first pull request! 🎉 |
fg91
pushed a commit
that referenced
this pull request
Aug 15, 2023
* reupload the agent-ctrl-c handler and grpc dependency Signed-off-by: Future Outlier <[email protected]> * image config annotation Signed-off-by: Future Outlier <[email protected]> * Trigger RTD build Signed-off-by: Future Outlier <[email protected]> * update grpc dependency (correct version) Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]>
Future-Outlier
added a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
…teorg#1782) * reupload the agent-ctrl-c handler and grpc dependency Signed-off-by: Future Outlier <[email protected]> * image config annotation Signed-off-by: Future Outlier <[email protected]> * Trigger RTD build Signed-off-by: Future Outlier <[email protected]> * update grpc dependency (correct version) Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As the title.
(Sorry for my git issue, I have to reopen a pull request)
Type
Are all requirements met?
Complete description
Is adding the unit test necessary?
Exiting the program is good enough for the function, if we need to return an empty structured dataset instead, please let me know.
Tracking Issue
#1687
#1778
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/