Agent get secret function #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the databricks agent
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Future Outlier <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1851 +/- ##
===========================================
+ Coverage 20.13% 31.80% +11.66%
===========================================
Files 337 468 +131
Lines 32427 38382 +5955
Branches 5857 2719 -3138
===========================================
+ Hits 6530 12206 +5676
- Misses 25731 26028 +297
+ Partials 166 148 -18
☔ View full report in Codecov by Sentry. |
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Sep 27, 2023
added 2 commits
September 27, 2023 08:57
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
added 2 commits
September 27, 2023 13:21
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Sep 28, 2023
Future-Outlier
added a commit
to Future-Outlier/flytekit
that referenced
this pull request
Oct 3, 2023
Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Type
Are all requirements met?
Complete description
We want to make the get secret function more reusable.
Tracking Issue
flyteorg/flyte#3936