Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make mlflow plugin work with python 3.11 #1855

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

bcvanmeurs
Copy link
Contributor

@bcvanmeurs bcvanmeurs commented Sep 27, 2023

TL;DR

Remove upper python constraint on flytekit-mlflow to allow for installation on 3.11, in line with other plugins.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

NA

Tracking Issue

NA

Follow-up issue

NA

@welcome
Copy link

welcome bot commented Sep 27, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@bcvanmeurs
Copy link
Contributor Author

Hi Team,
This is my first PR 🙌, hopefully more to follow. We are trying to use the plugin with python 3.11, but it is restricted. Is there any reason why that was the case? I couldn't find any.

@bcvanmeurs bcvanmeurs marked this pull request as ready for review September 27, 2023 11:39
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (af429f6) 20.13% compared to head (b85c3f6) 54.78%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1855       +/-   ##
===========================================
+ Coverage   20.13%   54.78%   +34.64%     
===========================================
  Files         337      294       -43     
  Lines       32427    22176    -10251     
  Branches     5857     3344     -2513     
===========================================
+ Hits         6530    12149     +5619     
+ Misses      25731     9865    -15866     
+ Partials      166      162        -4     

see 309 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cosmicBboy
Copy link
Contributor

thanks @bcvanmeurs and congrats on your first contribution to flytekit!

@cosmicBboy cosmicBboy merged commit 0ddde6f into flyteorg:master Sep 27, 2023
@welcome
Copy link

welcome bot commented Sep 27, 2023

Congrats on merging your first pull request! 🎉

Future-Outlier pushed a commit to Future-Outlier/flytekit that referenced this pull request Oct 3, 2023
Signed-off-by: Bram van Meurs <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants