Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Auth issue, where refresh token is expired #1873

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Fixes Auth issue, where refresh token is expired #1873

merged 3 commits into from
Oct 6, 2023

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Oct 5, 2023

TL;DR

Fixes error caused when refresh token is expired. This is intermittent.

Problem of type

❯ pyflyte run --remote  test2.py wf --n 10
Running Execution on Remote.
E1004 23:00:53.300669000 8616083776 hpack_parser.cc:853]               Error parsing metadata: error=invalid value key=content-type value=text/html
E1004 23:00:53.790464000 8616083776 hpack_parser.cc:853]               Error parsing metadata: error=invalid value key=content-type value=text/html
E1004 23:00:53.863833000 8616083776 hpack_parser.cc:853]               Error parsing metadata: error=invalid value key=content-type value=text/html
E1004 23:00:53.937017000 8616083776 hpack_parser.cc:853]               Error parsing metadata: error=invalid value key=content-type value=text/html
Failed with Exception Code: SYSTEM:Unknown
Underlying Exception: no refresh token available with which to refresh authorization credentials

Underlying Exception: no refresh token available with which to refresh authorization credentials

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (de8a5fe) 31.81% compared to head (154e09c) 55.02%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1873       +/-   ##
===========================================
+ Coverage   31.81%   55.02%   +23.20%     
===========================================
  Files         468      296      -172     
  Lines       38414    22219    -16195     
  Branches     5856     2173     -3683     
===========================================
+ Hits        12222    12225        +3     
+ Misses      26026     9845    -16181     
+ Partials      166      149       -17     
Files Coverage Δ
flytekit/clients/auth/auth_client.py 32.96% <0.00%> (ø)
flytekit/clients/auth/keyring.py 43.13% <0.00%> (-0.87%) ⬇️

... and 208 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -71,9 +71,8 @@ def delete(for_endpoint: str):
try:
_keyring.delete_password(for_endpoint, KeyringStore._access_token_key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just do three separate try/catches? to make sure we always clean up all three things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Fixed.

Signed-off-by: Ketan Umare <[email protected]>
@kumare3 kumare3 merged commit fb2a9f9 into master Oct 6, 2023
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants