change key path to SNOWFLAKE_PRIVATE_KEY #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HH <[email protected]>
hhcs9527
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: HH <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1879 +/- ##
==========================================
- Coverage 55.05% 53.83% -1.22%
==========================================
Files 296 279 -17
Lines 22241 21520 -721
Branches 3356 3357 +1
==========================================
- Hits 12244 11585 -659
+ Misses 9834 9772 -62
Partials 163 163
☔ View full report in Codecov by Sentry. |
pingsutw
approved these changes
Oct 6, 2023
Signed-off-by: HH <[email protected]>
|
hi @pingsutw , fix the lint error |
pingsutw
previously approved these changes
Oct 9, 2023
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
change key path to SNOWFLAKE_PRIVATE_KEY
Type
Are all requirements met?
Tracking Issue
Flyte Agent Ecosystem