Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate click option #1883

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove duplicate click option #1883

merged 1 commit into from
Oct 10, 2023

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Oct 9, 2023

TL;DR

Remove a duplicate option.

The @domain_option_dec already handles domain.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor changed the title duplicate option Remove duplicate click option Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b35af10) 55.05% compared to head (fd18483) 50.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
- Coverage   55.05%   50.66%   -4.40%     
==========================================
  Files         296      250      -46     
  Lines       22243    19972    -2271     
  Branches     3357     3357              
==========================================
- Hits        12245    10118    -2127     
+ Misses       9835     9691     -144     
  Partials      163      163              

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit 319ee60 into master Oct 10, 2023
67 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants