Add Databricks and Snowflake agent to Dockerfile #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the databricks agent
[pull] master from flyteorg:master
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Oct 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1905 +/- ##
=======================================
Coverage 54.90% 54.90%
=======================================
Files 298 298
Lines 22353 22353
Branches 3370 3370
=======================================
+ Hits 12273 12274 +1
+ Misses 9915 9914 -1
Partials 165 165 ☔ View full report in Codecov by Sentry. |
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* add snowflake and databricks agent Signed-off-by: Future Outlier <[email protected]> * resolbe conflicts Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
We are adding Databricks and Snowflake agents directly to the Dockerfile.
This enhancement ensures users can utilize these agents without manually building or editing the agent deployment image.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#3936