Auto download for fetch #1918
Merged
Auto download for fetch #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Umare <[email protected]>
kumare3
requested review from
wild-endeavor,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
- Coverage 62.81% 62.78% -0.04%
==========================================
Files 307 308 +1
Lines 22984 23014 +30
Branches 3490 3493 +3
==========================================
+ Hits 14438 14449 +11
- Misses 8124 8143 +19
Partials 422 422
☔ View full report in Codecov by Sentry. |
` pyflyte fetch --download-to /tmp/. flyte://v1/flytesnacks/development/f5dc81c5a8c6441d4a0a/rotaterotateimage/o/o0` Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
wild-endeavor
approved these changes
Nov 6, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* Auto download for fetch Signed-off-by: Ketan Umare <[email protected]> * Adds new fetch with download command ` pyflyte fetch --download-to /tmp/. flyte://v1/flytesnacks/development/f5dc81c5a8c6441d4a0a/rotaterotateimage/o/o0` Signed-off-by: Ketan Umare <[email protected]> * Auto download and improved some bugs Signed-off-by: Ketan Umare <[email protected]> * Updated fetch and hitl Signed-off-by: Ketan Umare <[email protected]> --------- Signed-off-by: Ketan Umare <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* Auto download for fetch Signed-off-by: Ketan Umare <[email protected]> * Adds new fetch with download command ` pyflyte fetch --download-to /tmp/. flyte://v1/flytesnacks/development/f5dc81c5a8c6441d4a0a/rotaterotateimage/o/o0` Signed-off-by: Ketan Umare <[email protected]> * Auto download and improved some bugs Signed-off-by: Ketan Umare <[email protected]> * Updated fetch and hitl Signed-off-by: Ketan Umare <[email protected]> --------- Signed-off-by: Ketan Umare <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
It should be possible to download a specific file/directory/dataset as long as you have cloud connection configured.
pflyte fetch flyte://...- just printsTo recursively download all data from a literal map use
--recursivepyflyte fetch --recursive flyte://v1/flytesnacks/development/f9da2e91e3c844a20b89/n0/i /tmp/inputsTo look at a specific value
to download that specific value
specify a destination directoryThis works out of the box for sandbox as long as this PR is used to generate the config file for sandbox - flyteorg/flytectl#440
The difference is that the config section as a storage configuration for minio.
Type
Are all requirements met?