Add Sections in the PR Template #1939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1939 +/- ##
=======================================
Coverage 62.69% 62.69%
=======================================
Files 313 313
Lines 23187 23187
Branches 3513 3513
=======================================
Hits 14536 14536
Misses 8229 8229
Partials 422 422 ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Nov 7, 2023
|
cc @eapolinario @wild-endeavor wdyt |
eapolinario
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Can we change comments to the style used in https://github.com/flyteorg/flyte/blob/master/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L9-L13 ?
No problem! |
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Nov 11, 2023
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Nov 11, 2023
…nto add-sections-in-pr-template
pingsutw
approved these changes
Nov 15, 2023
pingsutw
approved these changes
Nov 21, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* pr template update Signed-off-by: Future Outlier <[email protected]> * change pr template Signed-off-by: Future Outlier <[email protected]> * add kevin's advice Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* pr template update Signed-off-by: Future Outlier <[email protected]> * change pr template Signed-off-by: Future Outlier <[email protected]> * add kevin's advice Signed-off-by: Future Outlier <[email protected]> --------- Signed-off-by: Future Outlier <[email protected]> Co-authored-by: Future Outlier <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
As title.
Type
Are all requirements met?
Complete description
This change will improve the PR quality significantly.
Tracking Issue
flyteorg/flyte#4366
Related PRs
flyteorg/flyte#4367