Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pr] remove stale spec in data proxy #1984

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[pr] remove stale spec in data proxy #1984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions flytekit/clients/friendly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,6 @@ def get_upload_signed_url(
content_md5: bytes,
filename: typing.Optional[str] = None,
expires_in: typing.Optional[datetime.timedelta] = None,
artifact_spec: typing.Optional[artifacts_pb2.ArtifactSpec] = None,
) -> _data_proxy_pb2.CreateUploadLocationResponse:
"""
Get a signed url to be used during fast registration
Expand All @@ -997,8 +996,6 @@ def get_upload_signed_url(
:param filename: If provided this specifies a desired suffix for the generated location
:param expires_in: If provided this defines a requested expiration duration for
the generated url
:param artifact_spec: If provided, will be provided to the artifact service to specify things like LiteralType,
or name, tags or aliases that the users want to specify at upload time.
:rtype: flyteidl.service.dataproxy_pb2.CreateUploadLocationResponse
"""
expires_in_pb = None
Expand All @@ -1012,7 +1009,6 @@ def get_upload_signed_url(
content_md5=content_md5,
filename=filename,
expires_in=expires_in_pb,
artifact_spec=artifact_spec,
)
)

Expand Down
4 changes: 0 additions & 4 deletions flytekit/remote/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,16 +843,13 @@ def upload_file(
to_upload: pathlib.Path,
project: typing.Optional[str] = None,
domain: typing.Optional[str] = None,
artifact_spec: typing.Optional[artifacts_pb2.ArtifactSpec] = None,
) -> typing.Tuple[bytes, str]:
"""
Function will use remote's client to hash and then upload the file using Admin's data proxy service.

:param to_upload: Must be a single file
:param project: Project to upload under, if not supplied will use the remote's default
:param domain: Domain to upload under, if not specified will use the remote's default
:param artifact_spec: If provided, will be provided to the artifact service to specify things like LiteralType,
or name, tags or aliases that the users want to specify at upload time.
:return: The uploaded location.
"""
if not to_upload.is_file():
Expand All @@ -865,7 +862,6 @@ def upload_file(
domain=domain or self.default_domain,
content_md5=md5_bytes,
filename=to_upload.name,
artifact_spec=artifact_spec,
)

extra_headers = self.get_extra_headers_for_protocol(upload_location.native_url)
Expand Down
Loading