try removing multiple imports to resolve fast-mode issue #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: novahow <[email protected]>
novahow
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2110 +/- ##
===========================================
+ Coverage 71.79% 85.81% +14.01%
===========================================
Files 182 313 +131
Lines 18561 23503 +4942
Branches 3654 3511 -143
===========================================
+ Hits 13326 20169 +6843
+ Misses 4592 2726 -1866
+ Partials 643 608 -35 ☔ View full report in Codecov by Sentry. |
novahow
changed the title
pingsutw
reviewed
Jan 30, 2024
cosmicBboy
approved these changes
Jun 21, 2024
pingsutw
approved these changes
Jun 21, 2024
bgedik
pushed a commit
to bgedik/flytekit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: novahow <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: bugra.gedik <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: novahow <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#4716
Why are the changes needed?
Please refer to may example in flyteorg/flyte#4716 (comment)
When we have a python file that contains workflows, tasks, and launch plans and try to run that in fast mode, we get an error:
AssertionError: The cached values aren't the same as the current call argumentsThis happens because when executing the file, the launch_plan's
get_or_createmethod is invoked by the following snippet multiple times, thus theLaunchPlan.CACHEstores a workflow. After that when we're really creating a plan withstandard_scale_launch_plan = LaunchPlan.get_or_create(, the workflow of the plan is different from the workflow of the cached plan, which I haven't figured out the reason.What changes were proposed in this pull request?
My workaround is removing
exec_modulein the try block andimport_modulein the exception block so thatget_or_createwon't be invoked multiple timesHow was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link