Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verbose debug message #2227

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

austin362667
Copy link
Collaborator

Tracking issue

flyteorg/flyte#4762

Why are the changes needed?

We can omit too verbose debugging message when we merge
flyteorg/flyte#4924

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Austin Liu <[email protected]>

format

Signed-off-by: Austin Liu <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (7794d3a) to head (ac4f3b7).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   85.53%   84.74%   -0.80%     
==========================================
  Files         309      315       +6     
  Lines       23460    24142     +682     
  Branches     3630     3666      +36     
==========================================
+ Hits        20066    20458     +392     
- Misses       2752     3025     +273     
- Partials      642      659      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pingsutw pingsutw merged commit c999824 into flyteorg:master Mar 13, 2024
84 of 90 checks passed
austin362667 added a commit to austin362667/flytekit that referenced this pull request Mar 16, 2024
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
format

Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants