Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check servicer for agent #2232

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Add health check servicer for agent #2232

merged 3 commits into from
Mar 2, 2024

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 1, 2024

Tracking issue

flyteorg/flyte#3936

Why are the changes needed?

Add this service so we can use gRPC container probes to check if agent is healthy

What changes were proposed in this pull request?

Add HealthServicer

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

pingsutw added 2 commits March 1, 2024 13:22
Signed-off-by: Kevin Su <[email protected]>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 1, 2024
Signed-off-by: Kevin Su <[email protected]>
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.93%. Comparing base (784c08b) to head (8c1a38f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2232      +/-   ##
==========================================
- Coverage   85.94%   85.93%   -0.01%     
==========================================
  Files         315      315              
  Lines       24142    24142              
  Branches     3666     3666              
==========================================
- Hits        20749    20747       -2     
- Misses       2742     2743       +1     
- Partials      651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 1, 2024
@pingsutw pingsutw merged commit f66fa66 into master Mar 2, 2024
88 of 90 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants