-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement force push functionality in ImageSpec #2234
Merged
pingsutw
merged 15 commits into
flyteorg:master
from
jasonlai1218:add-image-spec-force-push
Mar 13, 2024
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5ba105d
feat: implement force push functionality in ImageSpec and ImageBuildE…
jasonlai1218 8a0ec90
- feat: implement force push functionality in image_spec class
jasonlai1218 4c2c396
refactor: improve handling of force push in image builds
jasonlai1218 aa364e3
chore: update default image tag variable in ic_result_4
jasonlai1218 057ff60
refactor: refactor `is_force_push` attribute in ImageSpec and ImageBu…
jasonlai1218 a688fbe
feat: enable force push in ImageSpec class and update tests
jasonlai1218 c7b4fcb
refactor: refactor variable names across files
jasonlai1218 5fd9f8f
Merge branch 'master' into add-image-spec-force-push
jasonlai1218 d3a0fb5
refactor: refactor class attributes in ImageSpec
jasonlai1218 7471785
refactor: refactor image building and registration logic
jasonlai1218 32d39c7
test: refactor image building and testing process
jasonlai1218 ab68d7b
Merge branch 'master' into add-image-spec-force-push
jasonlai1218 1cb8860
Add FLYTE_FORCE_PUSH_IMAGE_SPEC
pingsutw 7a71b57
Fix tests
pingsutw 9b6f58f
Merge branch 'master' of github.com:flyteorg/flytekit into add-image-…
pingsutw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update:
flytekit/flytekit/image_spec/image_spec.py
Line 248 in 632b2c2
such that the
force_push
field is not a part of the hash?