-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing '=' character from generated image tag hash value #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a bug where the tag contains equal signs - Add an assertion to check if the tag does not contain equal signs Signed-off-by: jason.lai <[email protected]>
- Modify assertion to check for inequality instead of absence of character in tag - Refactor image name calculation to use f-string interpolation Signed-off-by: jason.lai <[email protected]>
- Add print statements to display the generated tag - Update the tag generation process to remove trailing equals sign Signed-off-by: jason.lai <[email protected]>
- Remove `click.secho` calls for outputting the tag - Add `print` statements for outputting the tag Signed-off-by: jason.lai <[email protected]>
- Refactor tag generation code in `calculate_hash_from_image_spec` function Signed-off-by: jason.lai <[email protected]>
jasonlai1218
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
March 5, 2024 08:24
dosubot
bot
added
the
size:XS
This PR changes 0-9 lines, ignoring generated files.
label
Mar 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2240 +/- ##
=======================================
Coverage 85.98% 85.98%
=======================================
Files 320 320
Lines 24245 24250 +5
Branches 3666 3667 +1
=======================================
+ Hits 20847 20852 +5
Misses 2746 2746
Partials 652 652 ☔ View full report in Codecov by Sentry. |
- Update the image tag values in `test_run.py` - Remove ellipses from the image tag values Signed-off-by: jason.lai <[email protected]>
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Mar 6, 2024
pingsutw
approved these changes
Mar 6, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
) Signed-off-by: jason.lai <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
To remove
=
directly is more clarityWhat changes were proposed in this pull request?
How was this patch tested?
Setup process
FLYTE_SDK_LOGGING_LEVEL=20 pyflyte run --remote -p flytesnacks --domain development my_workflows/dev_image_spec.py wf
Screenshots
Check all the applicable boxes
Related PRs
Docs link