Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler dev images #2243

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Simpler dev images #2243

merged 3 commits into from
Mar 6, 2024

Conversation

eapolinario
Copy link
Collaborator

Tracking issue

NA

Why are the changes needed?

This PR proposes a simpler way to build dev images by exposing a make target and piping the setuptools pseudo version in.

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (1c0b228) to head (60491b4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
- Coverage   85.99%   85.98%   -0.01%     
==========================================
  Files         320      320              
  Lines       24250    24250              
  Branches     3667     3667              
==========================================
- Hits        20854    20852       -2     
- Misses       2745     2746       +1     
- Partials      651      652       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 6, 2024
@eapolinario eapolinario merged commit 632b2c2 into master Mar 6, 2024
91 of 92 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants