Capitalize flyte deck header names #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <[email protected]>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:XS
eapolinario
previously approved these changes
Mar 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2254 +/- ##
==========================================
- Coverage 83.36% 83.34% -0.03%
==========================================
Files 309 309
Lines 24010 24010
Branches 3478 3478
==========================================
- Hits 20015 20010 -5
- Misses 3375 3377 +2
- Partials 620 623 +3 ☔ View full report in Codecov by Sentry. |
pingsutw
previously approved these changes
Mar 11, 2024
pingsutw
reviewed
Mar 11, 2024
Signed-off-by: Thomas J. Fan <[email protected]>
dosubot
bot
added
size:S
…n/capitalize_deck_names
pingsutw
approved these changes
Mar 12, 2024
kumare3
approved these changes
Mar 13, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Mar 16, 2024
* Capitalize deck names Signed-off-by: Thomas J. Fan <[email protected]> * TST Fixes tests for names Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Co-authored-by: Kevin Su <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Capitalize deck names Signed-off-by: Thomas J. Fan <[email protected]> * TST Fixes tests for names Signed-off-by: Thomas J. Fan <[email protected]> --------- Signed-off-by: Thomas J. Fan <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This makes the header formatting in FlyteDeck consistent with the sidebar, which is also capitalized:
What changes were proposed in this pull request?
The header strings were updated.