Addl artf testing #2256
Merged
Addl artf testing #2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2256 +/- ##
==========================================
- Coverage 83.52% 83.36% -0.17%
==========================================
Files 296 309 +13
Lines 23244 24010 +766
Branches 3481 3478 -3
==========================================
+ Hits 19415 20015 +600
- Misses 3207 3375 +168
+ Partials 622 620 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:L
pingsutw
previously approved these changes
Mar 12, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Mar 12, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Made the
bind_partitionscall in artifact id spec callable multiple times, mainly to support the ability to just specify an artifact in the annotation, and do all bindings at run time, but also makes the id spec callable multiple times. Mostly just adding tests otherwise.The logic change is passing through the original artifacts time partition granularity where relevant, to the one in the output metadata object.
Why are the changes needed?
More testing is seen as a good thing.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link