Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monodocs #2261

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Fix monodocs #2261

merged 3 commits into from
Mar 12, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Mar 12, 2024

Fix docs.
thank you @eapolinario @pingsutw

Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 12, 2024
@wild-endeavor wild-endeavor changed the title test Fix monodocs Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (61a3e95) to head (6a868cd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   83.36%   77.49%   -5.87%     
==========================================
  Files         309      200     -109     
  Lines       24010    18644    -5366     
  Branches     3478     3478              
==========================================
- Hits        20015    14449    -5566     
- Misses       3375     3601     +226     
+ Partials      620      594      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Mar 12, 2024
@eapolinario eapolinario merged commit d23eb44 into master Mar 12, 2024
46 of 47 checks passed
austin362667 pushed a commit to austin362667/flytekit that referenced this pull request Mar 16, 2024
* test

Signed-off-by: Yee Hing Tong <[email protected]>

* future

Signed-off-by: Yee Hing Tong <[email protected]>

* comment

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
* test

Signed-off-by: Yee Hing Tong <[email protected]>

* future

Signed-off-by: Yee Hing Tong <[email protected]>

* comment

Signed-off-by: Yee Hing Tong <[email protected]>

---------

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants