fix limit option #2292
Merged
fix limit option #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: novahow <[email protected]>
novahow
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2292 +/- ##
==========================================
- Coverage 83.76% 83.35% -0.42%
==========================================
Files 329 311 -18
Lines 25002 24191 -811
Branches 3708 3496 -212
==========================================
- Hits 20943 20164 -779
+ Misses 3432 3399 -33
- Partials 627 628 +1 ☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Mar 29, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
flyteorg/flyte#5086 1. removed `--limit` option in `RemoteEntityGroup` 2. set `--limit` in `RunLevelParams` to show up instead of hidden. Signed-off-by: novahow <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5086
closes #5086
Why are the changes needed?
To remove misleading options in
pyflyte run. For more details, please refer to flyteorg/flyte#5086What changes were proposed in this pull request?
--limitoption inRemoteEntityGroup--limitinRunLevelParamsto show up instead of hidden.How was this patch tested?
make testSetup process
Screenshots
Output of
pyflyte runCheck all the applicable boxes
Related PRs
Docs link