Gz encoding #2306
Merged
Gz encoding #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2306 +/- ##
==========================================
- Coverage 83.89% 83.47% -0.43%
==========================================
Files 342 324 -18
Lines 25483 24723 -760
Branches 3725 3519 -206
==========================================
- Hits 21380 20637 -743
+ Misses 3472 3453 -19
- Partials 631 633 +2 ☔ View full report in Codecov by Sentry. |
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Mar 29, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* wip, make a sandbox test Signed-off-by: Yee Hing Tong <[email protected]> * gzip encoding Signed-off-by: Yee Hing Tong <[email protected]> * revert Signed-off-by: Yee Hing Tong <[email protected]> * fix test Signed-off-by: Yee Hing Tong <[email protected]> * lint Signed-off-by: Yee Hing Tong <[email protected]> * test Signed-off-by: Yee Hing Tong <[email protected]> --------- Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Short of scanning the file using something like this which is already merged, we can do a simple extension check for gzip specifically. As/if this grows out of hand, we can refactor.
What changes were proposed in this pull request?
Just a simple file extension match for now.
How was this patch tested?
Tested locally.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link