Run ignore query #2322
Merged
Run ignore query #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2322 +/- ##
==========================================
- Coverage 83.79% 81.88% -1.91%
==========================================
Files 338 270 -68
Lines 25407 22457 -2950
Branches 3734 3542 -192
==========================================
- Hits 21291 18390 -2901
+ Misses 3485 3440 -45
+ Partials 631 627 -4 ☔ View full report in Codecov by Sentry. |
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:M
Signed-off-by: Yee Hing Tong <[email protected]>
dosubot
bot
added
size:L
Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
approved these changes
Apr 3, 2024
| @@ -274,7 +293,7 @@ def modify_literal_uris(lit: Literal): | |||
| SimpleType.STRING: click.STRING, | |||
| SimpleType.BOOLEAN: click.BOOL, | |||
| SimpleType.DURATION: DurationParamType(), | |||
| SimpleType.DATETIME: click.DateTime(), | |||
| SimpleType.DATETIME: DateTimeType(), | |||
pingsutw
approved these changes
Apr 3, 2024
ChungYujoyce
pushed a commit
to ChungYujoyce/flytekit
that referenced
this pull request
Apr 5, 2024
When a query is detected, don't do anything, and just say that it'll be resolved. If running locally though, it must be specified. Signed-off-by: Yee Hing Tong <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
When a query is detected, don't do anything, and just say that it'll be resolved. If running locally though, it must be specified. Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When a query is detected, don't do anything, and just say that it'll be resolved. If running locally though, it must be specified.
What changes were proposed in this pull request?
Make it so that pyflyte just doesn't pass along queries.
How was this patch tested?
Tested locally, tested against union, and tested with local data
Setup process
Screenshots
Working
Help screen
Local error
Check all the applicable boxes
Related PRs
Docs link