don't return triton image as a functools.partial #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
dosubot
bot
added
the
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2326 +/- ##
==========================================
- Coverage 83.09% 83.05% -0.05%
==========================================
Files 324 324
Lines 24853 24852 -1
Branches 3758 3545 -213
==========================================
- Hits 20651 20640 -11
- Misses 3581 3590 +9
- Partials 621 622 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Samhita Alla <[email protected]>
samhita-alla
changed the title
dosubot
bot
added
size:S
samhita-alla
changed the title
pingsutw
approved these changes
Apr 4, 2024
eapolinario
approved these changes
Apr 4, 2024
ChungYujoyce
pushed a commit
to ChungYujoyce/flytekit
that referenced
this pull request
Apr 5, 2024
* move triton image code from mixin to task Signed-off-by: Samhita Alla <[email protected]> * don't return triton image partial Signed-off-by: Samhita Alla <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
* move triton image code from mixin to task Signed-off-by: Samhita Alla <[email protected]> * don't return triton image partial Signed-off-by: Samhita Alla <[email protected]> --------- Signed-off-by: Samhita Alla <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
functools.partialis not JSON serializable. hence, replacing partial with string.What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link