Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name to union param #2329

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add name to union param #2329

merged 1 commit into from
Apr 4, 2024

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Apr 4, 2024 •
edited
Loading

Why are the changes needed?

If you had a union type, pyflyte run was failing when you ran --help with

  File "/Users/ytong/envs/experiments/lib/python3.11/site-packages/click/core.py", line 2220, in make_metavar
    metavar = self.type.name.upper()
              ^^^^^^^^^^^^^^

'UnionParamType' object has no attribute 'name'

This just adds the name property.

How was this patch tested?

image

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@wild-endeavor
fix
f021635 
Signed-off-by: Yee Hing Tong <[email protected]>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by maintainer label Apr 4, 2024
@wild-endeavor wild-endeavor changed the title fix Add name to union param Apr 4, 2024
@wild-endeavor wild-endeavor merged commit ce0d2cb into master Apr 4, 2024
47 checks passed
ChungYujoyce pushed a commit to ChungYujoyce/flytekit that referenced this pull request Apr 5, 2024
@wild-endeavor @ChungYujoyce
Add name to union param (flyteorg#2329)
6d22061 
Signed-off-by: Yee Hing Tong <[email protected]>
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
@wild-endeavor @fiedlerNr9
Add name to union param (#2329)
34a07ed 
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingsutw pingsutw pingsutw approved these changes

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla is a code owner

Assignees
No one assigned
Labels
lgtm This PR has been approved by maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wild-endeavor @pingsutw