Consistent formatting for artifact id spec #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2351 +/- ##
===========================================
- Coverage 83.04% 42.32% -40.72%
===========================================
Files 324 180 -144
Lines 24861 18160 -6701
Branches 3547 3554 +7
===========================================
- Hits 20645 7686 -12959
- Misses 3591 10383 +6792
+ Partials 625 91 -534 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
pingsutw
approved these changes
Apr 15, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The new artifact ID causes weird issues with the metadata field. The field itself is not used I don't think for the vast majority of Flyte, but is included in Admin's digest check, which is causing repeat registrations to fail with
Had to amend an unrelated Azure FS test because of fsspec/adlfs#270. We started picking up the latest version of adlfs over the weekend which is causing the test to fail.
What changes were proposed in this pull request?
Add a pretty print to the object, which should remediate the conflict at least.
How was this patch tested?
Unit tested and tested register with previously failing scenario.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link