Add default inputs to version hash #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2024 14:47
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:M
Signed-off-by: Kevin Su <[email protected]>
thomasjpfan
reviewed
Apr 17, 2024
wild-endeavor
approved these changes
Apr 24, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 9, 2024
Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
3 tasks
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Failed to run a workflow again when using
datetime.datetimeas default input because flytekit will try to register the same version of LP with the different default inputWhat changes were proposed in this pull request?
Add default inputs to version hash
How was this patch tested?
Integration test and pyflyte run
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA