Use grpc metadata limit from Admin #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
2 tasks
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
changed the title
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
dosubot
bot
added
the
size:XS
eapolinario
approved these changes
Apr 19, 2024
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Admin already gates large error messages, but flytekit does not set the max metadata size. The default is 16KB, so now we're bumping it up to roughly 32KB, in line with the cutoff from Admin. Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5224
Why are the changes needed?
Admin already gates large error messages, but flytekit does not set the max metadata size. The default is 16KB, so now we're bumping it up to roughly 32KB, in line with the cutoff from Admin.
What changes were proposed in this pull request?
Add a grpc dial option to the channel to configure max metadata size.
How was this patch tested?
This was tested by artificially creating a fake large error message in Admin (larger than 32KB in size) and confirming that it was received correctly by flytectl but not by flytekit. Adding this option lets flytekit receive the error correctly.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link