Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default serialization settings if serialization_settings is None #2367

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

Failed to register a workflow when serialization settings is None

            if create_default_launchplan:
                if not og_entity:
                    raise user_exceptions.FlyteValueException(
                        "To create default launch plan, please pass in the original flytekit workflow `og_entity`"
                    )
    
                # Let us also create a default launch-plan, ideally the default launchplan should be added
                # to the orderedDict, but we do not.
                self.file_access._get_upload_signed_url_fn = functools.partial(
>                   self.client.get_upload_signed_url, project=settings.project, domain=settings.domain
                )
E               AttributeError: 'NoneType' object has no attribute 'project'

What changes were proposed in this pull request?

Create a default serialization settings if it's None

How was this patch tested?

@task(container_image=image_spec)
def t2(second: int):
    sleep(second)


@workflow
def wf(second: int = 60):
    for i in range(10):
        t2(second=second)

flyte_workflow = remote.register_workflow(
        entity=wf, version=version
    )
    exe = remote.execute(
        entity=flyte_workflow, inputs={}, wait=False, options=Options(max_parallelism=3)
    )

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 22, 2024
@pingsutw pingsutw merged commit 069f87b into master Apr 24, 2024
47 checks passed
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants