Query by default when missing #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yee Hing Tong <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2379 +/- ##
===========================================
+ Coverage 52.39% 86.52% +34.13%
===========================================
Files 201 3 -198
Lines 19250 141 -19109
Branches 3568 0 -3568
===========================================
- Hits 10086 122 -9964
+ Misses 8731 19 -8712
+ Partials 433 0 -433 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yee Hing Tong <[email protected]>
wild-endeavor
requested review from
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
wild-endeavor
changed the title
wild-endeavor
changed the title
eapolinario
approved these changes
Apr 25, 2024
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 9, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
austin362667
pushed a commit
to austin362667/flytekit
that referenced
this pull request
May 10, 2024
Signed-off-by: Yee Hing Tong <[email protected]>
fiedlerNr9
pushed a commit
that referenced
this pull request
Jul 25, 2024
Signed-off-by: Yee Hing Tong <[email protected]> Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
This is just a convenience change.
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link