Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant secho() #2385

Merged

Conversation

austin362667
Copy link
Collaborator

Tracking issue

None

Why are the changes needed?

CLI (flytekit/tools/repo.py) shows redundant status message when registration.

What changes were proposed in this pull request?

Remove redundant secho().

How was this patch tested?

Register with and without this secho().

Setup process

pyflyte register wf.py

Screenshots

  1. Before removing
    image

  2. afte removing
    image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Austin Liu <[email protected]>
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@pingsutw pingsutw merged commit 4d036ce into flyteorg:master Apr 29, 2024
47 checks passed
austin362667 added a commit to austin362667/flytekit that referenced this pull request May 9, 2024
austin362667 added a commit to austin362667/flytekit that referenced this pull request May 10, 2024
fiedlerNr9 pushed a commit that referenced this pull request Jul 25, 2024
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Jan Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants