-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate custom_info Dict through agent Resource #2426
Propagate custom_info Dict through agent Resource #2426
Conversation
51c3825
to
67865b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2426 +/- ##
==========================================
+ Coverage 72.10% 77.62% +5.51%
==========================================
Files 181 238 +57
Lines 18395 20841 +2446
Branches 3601 3600 -1
==========================================
+ Hits 13264 16178 +2914
+ Misses 4506 4062 -444
+ Partials 625 601 -24 ☔ View full report in Codecov by Sentry. |
1218914
to
b337afe
Compare
f237b5c
to
2fd654a
Compare
Tracking issue: flyteorg/flyte#5603 |
@ddl-rliu Could you rebase the PR to fix the CI error? |
2fd654a
to
a9c9c46
Compare
f29140d
to
d56aea3
Compare
Fixed! |
@ddl-rliu overall lgtm, some tests are failing though. |
- The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR flyteorg#2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: ddl-rliu <[email protected]>
Signed-off-by: ddl-rliu <[email protected]>
46b56ad
to
1a6348c
Compare
test errors should be fixed now 👍 |
* Propagate custom_info Dict through agent Resource - The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR flyteorg#2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: ddl-rliu <[email protected]> * Fix test Signed-off-by: ddl-rliu <[email protected]> --------- Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: ddl-rliu <[email protected]> Co-authored-by: ddl-rliu <[email protected]>
* Propagate custom_info Dict through agent Resource - The agent defines a Resource return type with values: * outputs * message * log_links * phase These are all a part of the underlying protobuf contract defined in flyteidl. However, the message field custom_info from the protobuf is not here google.protobuf.Struct custom_info https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140 This field was added in flyteorg/flyte#4874 but never made it into the corresponding flytekit PR #2146 - It's useful for agents to return additional metadata about the job, and it looks like custom_info is the intended location - Make a minor refactor to how the agent responds to requests that return Resource by implementing to_flyte_idl / from_flyte_idl directly Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: ddl-rliu <[email protected]> * Fix test Signed-off-by: ddl-rliu <[email protected]> --------- Signed-off-by: ddl-ebrown <[email protected]> Signed-off-by: ddl-rliu <[email protected]> Co-authored-by: ddl-rliu <[email protected]>
See also flyteorg/flyte#5391
Tracking issue
Why are the changes needed?
The agent defines a Resource return type with values:
These are all a part of the underlying protobuf contract defined in
flyteidl.
However, the message field custom_info from the protobuf is not here
google.protobuf.Struct custom_info
https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140
This field was added in Agents protocol refactor flyte#4874
but never made it into the corresponding flytekit PR
Add SyncAgentBase #2146
It's useful for agents to return additional metadata about the job,
and it looks like custom_info is the intended location
Make a minor refactor to how the agent responds to requests that
return Resource by implementing to_flyte_idl / from_flyte_idl
directly
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link