Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing dataclasses which require list protobuf deserialization #2614

Closed
wants to merge 5 commits into from

protobuf semantics differs on py3.9

c411fc7
Select commit
Loading
Failed to load commit list.
Closed

Allowing dataclasses which require list protobuf deserialization #2614

protobuf semantics differs on py3.9
c411fc7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 15, 2024 in 0s

45.00% (-49.09%) compared to 556dad2

View this Pull Request on Codecov

45.00% (-49.09%) compared to 556dad2

Details

Codecov Report

Attention: Patch coverage is 6.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 45.00%. Comparing base (556dad2) to head (c411fc7).
Report is 2 commits behind head on master.

Files Patch % Lines
flytekit/core/type_engine.py 6.66% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2614       +/-   ##
===========================================
- Coverage   94.08%   45.00%   -49.09%     
===========================================
  Files          32      223      +191     
  Lines        1842    20651    +18809     
  Branches        0     4012     +4012     
===========================================
+ Hits         1733     9293     +7560     
- Misses        109    11230    +11121     
- Partials        0      128      +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.