Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for TypeTransformerFailedError #2648

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Update error message for TypeTransformerFailedError #2648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b067d0
fix: add check literal for each transformer
wayner0628 Aug 3, 2024
815f7ab
fix: float transformer should also handle integer
wayner0628 Aug 3, 2024
6460cf7
fix: None type check logical error
wayner0628 Aug 4, 2024
b7fa124
update error
pingsutw Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flytekit/core/base_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def local_execute(
except TypeTransformerFailedError as exc:
msg = f"Failed to convert inputs of task '{self.name}':\n {exc}"
logger.error(msg)
raise TypeError(msg) from exc
raise TypeError(msg) from None
input_literal_map = _literal_models.LiteralMap(literals=literals)

# if metadata.cache is set, check memoized version
Expand Down Expand Up @@ -724,7 +724,7 @@ def dispatch_execute(
except Exception as exc:
msg = f"Failed to convert inputs of task '{self.name}':\n {exc}"
logger.error(msg)
raise type(exc)(msg) from exc
raise type(exc)(msg) from None

# TODO: Logger should auto inject the current context information to indicate if the task is running within
# a workflow or a subworkflow etc
Expand Down
2 changes: 1 addition & 1 deletion flytekit/core/promise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def my_wf(in1: int, in2: int) -> int:
v = resolve_attr_path_in_promise(v)
result[k] = TypeEngine.to_literal(ctx, v, t, var.type)
except TypeTransformerFailedError as exc:
raise TypeTransformerFailedError(f"Failed argument '{k}': {exc}") from exc
raise TypeTransformerFailedError(f"Failed argument '{k}': {exc}") from None

return result

Expand Down
2 changes: 1 addition & 1 deletion flytekit/core/type_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ def literal_map_to_kwargs(
try:
kwargs[k] = TypeEngine.to_python_value(ctx, lm.literals[k], python_interface_inputs[k])
except TypeTransformerFailedError as exc:
raise TypeTransformerFailedError(f"Error converting input '{k}' at position {i}:\n {exc}") from exc
raise TypeTransformerFailedError(f"Error converting input '{k}' at position {i}:\n {exc}") from None
return kwargs

@classmethod
Expand Down
Loading