Modify test_array_node.py to support running in python 3.8 #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
requested review from
wild-endeavor,
kumare3,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
thomasjpfan
approved these changes
Aug 5, 2024
mao3267
pushed a commit
to mao3267/flytekit
that referenced
this pull request
Aug 9, 2024
…2652) Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Signed-off-by: mao3267 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
We run nightly tests in all supported python versions (e.g. https://github.com/flyteorg/flytekit/actions/runs/10249523395), but tests have been failing in python 3.8. This PR fixes the remaining ones.
What changes were proposed in this pull request?
Use the deprecated
typing.Listto define a list. Once we drop support for python 3.8 later in the year we can go back to using the native collections everywhere in the codebase.How was this patch tested?
Ran tests locally using python 3.8.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link