-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeEngine] Schema version priority for union dataclass comparison #2959
[TypeEngine] Schema version priority for union dataclass comparison #2959
Conversation
Signed-off-by: Future-Outlier <[email protected]>
…er-for-union-dataclass-comparison' into schema-version-priority-for-union-dataclass-comparison
Signed-off-by: mao3267 <[email protected]>
Signed-off-by: mao3267 <[email protected]>
…ema-version-priority-for-union-dataclass-comparison
Signed-off-by: mao3267 <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2959 +/- ##
===========================================
- Coverage 92.54% 51.35% -41.20%
===========================================
Files 7 200 +193
Lines 483 20921 +20438
Branches 0 2693 +2693
===========================================
+ Hits 447 10743 +10296
- Misses 36 9579 +9543
- Partials 0 599 +599 ☔ View full report in Codecov by Sentry. |
…lyteorg#2959) * Union Dataclass Ambiguos Error Signed-off-by: Future-Outlier <[email protected]> * fix: change schema to 2020-12 from mashumaro Signed-off-by: mao3267 <[email protected]> * fix: handle dict type while generating attr from dataclass json mixin Signed-off-by: mao3267 <[email protected]> * fix: update comments and use title to check nested dataclass Signed-off-by: mao3267 <[email protected]> * LGTM Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: Future-Outlier <[email protected]> Signed-off-by: mao3267 <[email protected]> Co-authored-by: Future-Outlier <[email protected]>
Tracking issue
flyteorg/flyte#5489
Why are the changes needed?
Since we plan to primarily support newer versions of JSON schemas in the future, we would like to update the JSON schema version priority in the
literal
metadata field.What changes were proposed in this pull request?
dict
while generating attribute list ingenerate_attribute_list_from_dataclass_json_mixin
function.How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#2932
#2859
Docs link
None