Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Transformer] Pydantic guess python type #2976

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Future-Outlier
Copy link
Member

@Future-Outlier Future-Outlier commented Dec 4, 2024

Tracking issue

flyteorg/flyte#5318

Related issue

pydantic/pydantic#643
flyteorg/flyte#6081

Why are the changes needed?

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 35 lines in your changes missing coverage. Please review.

Project coverage is 52.51%. Comparing base (47fe660) to head (0feb92e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...lytekit/extras/pydantic_transformer/transformer.py 22.22% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2976      +/-   ##
==========================================
+ Coverage   51.35%   52.51%   +1.16%     
==========================================
  Files         200      200              
  Lines       20940    21041     +101     
  Branches     2697     2716      +19     
==========================================
+ Hits        10753    11050     +297     
+ Misses       9586     9464     -122     
+ Partials      601      527      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant