Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin ollama version #2997

Merged
merged 1 commit into from
Dec 13, 2024
Merged

pin ollama version #2997

merged 1 commit into from
Dec 13, 2024

Conversation

samhita-alla
Copy link
Contributor

Tracking issue

Why are the changes needed?

Must pin Ollama, as versions >= 0.4.0 result in an 'invalid digest' error due to this issue.

What changes were proposed in this pull request?

Pinned the Ollama version in the create model container.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Samhita Alla <[email protected]>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.69%. Comparing base (f99d50e) to head (ec36520).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2997       +/-   ##
===========================================
+ Coverage   51.08%   76.69%   +25.61%     
===========================================
  Files         201      201               
  Lines       21231    21231               
  Branches     2731     2731               
===========================================
+ Hits        10846    16284     +5438     
+ Misses       9787     4206     -5581     
- Partials      598      741      +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue to remove the pin once ollama/ollama-python#277 (comment) is resolved?

@eapolinario eapolinario merged commit 576fb26 into master Dec 13, 2024
102 of 104 checks passed
wild-endeavor pushed a commit that referenced this pull request Dec 16, 2024
Signed-off-by: Samhita Alla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants