Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin READMEs #723

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Plugin READMEs #723

merged 4 commits into from
Oct 26, 2021

Conversation

samhita-alla
Copy link
Contributor

Signed-off-by: Samhita Alla [email protected]

TL;DR

Add plugin READMEs.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

https://github.com/lyft/flyte/issues/

Follow-up issue

NA
OR
https://github.com/lyft/flyte/issues/

Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
@samhita-alla samhita-alla changed the title Plugin readme Plugin READMEs Oct 26, 2021
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #723 (7bf78a3) into master (782bb34) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   85.76%   85.80%   +0.04%     
==========================================
  Files         358      358              
  Lines       29778    29793      +15     
  Branches     2428     2428              
==========================================
+ Hits        25538    25564      +26     
+ Misses       3601     3590      -11     
  Partials      639      639              
Impacted Files Coverage Δ
flytekit/models/common.py 89.09% <0.00%> (-7.31%) ⬇️
flytekit/models/admin/common.py 97.47% <0.00%> (-2.53%) ⬇️
flytekit/models/core/types.py 98.67% <0.00%> (-1.33%) ⬇️
flytekit/remote/component_nodes.py 80.00% <0.00%> (-0.33%) ⬇️
flytekit/remote/nodes.py 72.30% <0.00%> (-0.22%) ⬇️
flytekit/types/file/file.py 90.78% <0.00%> (-0.07%) ⬇️
flytekit/core/promise.py 77.95% <0.00%> (-0.05%) ⬇️
flytekit/clis/flyte_cli/main.py 47.24% <0.00%> (-0.05%) ⬇️
tests/flytekit/unit/core/test_type_engine.py 99.71% <0.00%> (-0.01%) ⬇️
flytekit/core/shim_task.py 77.27% <0.00%> (ø)
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782bb34...7bf78a3. Read the comment docs.

Copy link
Contributor

@kumare3 kumare3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@kumare3 kumare3 merged commit f876a33 into master Oct 26, 2021
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
Signed-off-by: Robert Everson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants