Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common models to flytekit __init__ #729

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Conversation

wild-endeavor
Copy link
Contributor

TL;DR

Add common models to flytekit init

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Signed-off-by: Yee Hing Tong <[email protected]>
eapolinario
eapolinario previously approved these changes Oct 29, 2021
Signed-off-by: Yee Hing Tong <[email protected]>
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #729 (0140acb) into master (c6efe63) will not change coverage.
The diff coverage is n/a.

❗ Current head 0140acb differs from pull request most recent head ce76b69. Consider uploading reports for the commit ce76b69 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #729   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files         362      362           
  Lines       30007    30007           
  Branches     2444     2444           
=======================================
  Hits        25743    25743           
  Misses       3621     3621           
  Partials      643      643           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6efe63...ce76b69. Read the comment docs.

Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
@wild-endeavor wild-endeavor merged commit d33fb75 into master Oct 29, 2021
reverson pushed a commit to reverson/flytekit that referenced this pull request May 27, 2022
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Robert Everson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants